search

phetsims / center-and-variability

"Center and Variability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Use `ResetAllButton.isResettingAllProperty` to mute sound in `IntervalToolNode` #622

Closed jbphet closed 5 months ago

jbphet commented 5 months ago

In https://github.com/phetsims/tambo/issues/190 a more globally available flag was created that can be used to determine if a "reset all" action is in progress. This could be used in IntervalToolNode to mute sound generation during reset.

jbphet commented 5 months ago

Changes made. Assigning to @samreid and @marlitas for review, as they are listed as the responsible devs for this sim.

UPDATE by @samreid: changed the handles of the "assigning to" in the previous sentence.

samreid commented 5 months ago

I'll take a look.

samreid commented 5 months ago

I reviewed the code and tested with mouse and keyboard, everything seems good, thanks, closing.