search

phetsims / center-and-variability

"Center and Variability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Use soccer-common strings when re-published. #624

Open marlitas opened 2 months ago

marlitas commented 2 months ago

From https://github.com/phetsims/soccer-common/issues/15. We consolidated some strings used in both Mean Share and Balance and Center and Variability in soccer-common. When CAV is republished it should be accessing the following strings from soccer-common and remove it's sim specific references. 

  "needAtLeastOneKick": {
    "value": "Need at least one kick"
  },
  "keyboardHelpDialog.grabOrReleaseItemHeading": {
    "value": "Soccer Ball"
  },
  "keyboardHelpDialog.grabOrReleaseItem": {
    "value": "soccer ball"
  },
  "keyboardHelpDialog.moveHeading": {
    "value": "Move Soccer Ball"
  },
  "keyboardHelpDialog.moveDescription": {
    "value": "Move grabbed soccer ball"
  }
jbphet commented 2 months ago

Please note that when this is done, any string translations that exist in C&V that do not exist in the common versions should be added to the common string translations. Also, the strings that are no longer used in the C&V string files should be removed for cleanliness.