search

phetsims / charges-and-fields

"Charges And Fields" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Equipotential isn't translated to state simulation #148

Open JRomero0613 opened 6 years ago

JRomero0613 commented 6 years ago

Test Device: PC Laptop

OS: Windows 10 v. 1803

Browser: Google Chrome v. 67.0.3396.87

Problem Description: For phetsims/QA#128 when using the state wrapper with the simulation and drawing the region of equipotential, the equipotential is not translated to the smaller sim. In v. 1.0.1-rc.1 no equipotential line is drawn at all in the smaller sim. In master the first equipotential line is drawn in the smaller sim, however any lines afterwards are not drawn. After no more equipotential lines are drawn changing the options such as electric field and grid are not translated to the smaller sim.

Screenshot: The first screenshot is of version 1.0.1-rc.1 where no equipotential lines are drawn in the smaller sim. caf_equipotential The second screenshot is of the master version where the first equipotential line is drawn. caf_equipotential_master_2

zepumph commented 6 years ago

Looks like the version in master and https://phet-io.colorado.edu/sims/charges-and-fields/1.0.0-phetio/wrappers/state/state.html?sim=charges-and-fields isn't storing state either. This will be worked on when the next phet-io release out of master takes place. Renaming to remove version specific suffix, and unassigning.

phet-steele commented 6 years ago

The error I receive:

Uncaught Error: Assertion failed: addChildInstance should have registered element: chargesAndFields.chargesAndFieldsScreen.model.electricPotentialLines_0
    at window.assertions.assertFunction (assert.js:22)
    at create (phetio.js?bust=1531935073868:181)
    at phetio.js?bust=1531935073868:240
    at Array.forEach (<anonymous>)
    at iterate (phetio.js?bust=1531935073868:237)
    at Phetio.setState (phetio.js?bust=1531935073868:274)
    at PhETIO.implementation (PhETIO.js?bust=1531935073868:197)
    at PhetioCommandProcessor.invoke (phetioCommandProcessor.js?bust=1531935073868:261)
    at PhetioCommandProcessor.handleSingleInvoke (phetioCommandProcessor.js?bust=1531935073868:119)
    at PhetioCommandProcessor.handleRequest (phetioCommandProcessor.js?bust=1531935073868:160)