search

phetsims / charges-and-fields

"Charges And Fields" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
9 stars 7 forks source link

sim title is improperly cased #165

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

This is a minor nit about the title of this sim, "Charges And Fields".

For titlecase in general, the word "and" should be lowercase, i.e. "Charges and Fields".

Other sims appear to follow the titlecase convention; "Balloons and Static Electricity", "Energy Forms and Changes", "Isotopes and Atomic Mass", "Masses and Springs", ...

arouinfar commented 4 years ago

YES! This has bothered me for awhile now, and was reported in #152 (I believe we also noticed this not long after 1.0 but for priority reasons, decided to punt on it). This discrepancy in casing can cause some strange issues on the website. For example the table of sims under Desktop/Laptop Computer on the Offline Access page lists the sim twice.

image

The HTML5 version of Gravity and Orbits is also improperly cased, so if we decide to fix this sim, we should do the same for GAO.

ariel-phet commented 4 years ago

@pixelzoom is this something that can be fixed on the website, or does it need to be fixed in sim code as a "simple" maintenance release?

pixelzoom commented 4 years ago

It needs to be changed in charges-and-fields-strings_en.json in master:

  "charges-and-fields.title": {
    "value": "Charges And Fields"
  },

If you want a maintenance release, also change charges-and-fields-strings_en.json in the current release branch, then republish.

I don't know where the title that appears on the website comes from.

ariel-phet commented 4 years ago

@pixelzoom do you mind doing this Maintenance release? Seems fairly straightforward. I am pretty confident that the sim title on the website comes from the sim strings (so that way there is not a conflict between title of the sims and title on the website or translated versions for such).

ariel-phet commented 4 years ago

And at low priority, when ever you feel like ticking something off, no rush.

pixelzoom commented 4 years ago

Done:

@ariel-phet FYI. Closing.