phetsims / charges-and-fields

"Charges And Fields" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
9 stars 7 forks source link

Issue with measuringTapeInputListener.dragBounds #168

Open samreid opened 4 years ago

samreid commented 4 years ago

In 47a2fbdef08fe884ba3dfffc2c2c14e3f2c207c9 measuringTapeMovableDragHandler changed from SimpleDragHandler to Object literal. Master currently has this code:

https://github.com/phetsims/charges-and-fields/blob/f43effc3dad2d1893c0a749f2c340dbd96e7b078/js/charges-and-fields/view/ChargesAndFieldsToolboxPanel.js#L131-L136

// no need to dispose of this link since this is present for the lifetime of the sim
availableModelBoundsProperty.link( bounds => {

  // TODO: did this mean to say measuringTape.dragBounds???
  measuringTapeInputListener.dragBounds = bounds;
} );

However, this dragBounds doesn't appear to be doing anything. I can't tell if it should be changed to measuringTape.dragBounds = bounds like in charges-and-fields/js/charges-and-fields/view/ChargesAndFieldsScreenView.js or whether the line is altogether unnecessary.