Refactor of hasMagneticField

phetsims / charges-and-fields

"Charges And Fields" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

9 stars 7 forks source link

Closed veillette closed 4 years ago

veillette commented 4 years ago

While commenting on #171, I noticed that

   const hasMagneticField = this.model.getElectricField( position ).magnitude !== 0;

It would be more useful to rename this variable as hasElectricField.

veillette commented 4 years ago

Assigning to @samreid since he has made of lot of recent commits as part of Phet-IO on this simulation.

samreid commented 4 years ago

Thanks @veillette, I'll take a look.

samreid commented 4 years ago

Fixed, closing.