phetsims / chipper

Tools for developing and building PhET interactive simulations.
MIT License
11 stars 14 forks source link

Can we replace some/all sim variants with query parameters? #1153

Open samreid opened 2 years ago

samreid commented 2 years ago

Discovered in https://github.com/phetsims/circuit-construction-kit-common/issues/777. CCK has a lot of extra overhead from having separate sims for the "virtual lab" variants. This introduces 2 extra repos which need to be maintained, released, patched, etc. From an engineering standpoint, it seems preferable to publish one sim and add a ?virtualLab query parameter. We could also benefit from this approach in beers-law-lab & concentration, and cases like that.

Places where we would need support:

Would this be worth the added complexity? Tagging for dev meeting discussion, but also labeling as epic since if we agree to work on it, it would be epic-level effort.

zepumph commented 2 years ago

Discussed at dev meeting today:

This would be awesome for:

Some issues with this approach:

@jonathanolson: This was the java approach, and we didn't continue with this into HTML for a reason. @pixelzoom: With these "flavors", we couldn't version them separately, it was all or nothing. It didn't match the view of the products that users have.

All devs, please note in this issue over the next year any pain points you experience related to this, and we will see if these costs are worth this effort.