phetsims / chipper

Tools for developing and building PhET interactive simulations.
http://scenerystack.org/
MIT License
12 stars 14 forks source link

Convert phetioCompareAPIs to Typescript #1526

Open zepumph opened 1 week ago

zepumph commented 1 week ago

https://github.com/phetsims/phet-io/issues/1951 https://github.com/phetsims/perennial/issues/410 https://github.com/phetsims/perennial/issues/403 https://github.com/phetsims/chipper/issues/1465

This typescript module can then be used in sim AND build-tools code.

zepumph commented 5 days ago
zepumph commented 4 days ago

I got an error when building phet-io with this import:

Error: Cannot find module '../../../chipper/js/phet-io/phetioCompareAPIs.js'

https://stackoverflow.com/questions/45968302/webpack-module-not-found-error-cant-resolve-with-relative-path

zepumph commented 4 days ago

Converted and fixed in the above. The webpack build was ignoring files from /phet-io/ in phet brand build (what phet-io-wrappers standalone was build in).

zepumph commented 4 days ago

@samreid can you please give a spotcheck. Mostly for the typescript in chipper/js/phet-io/

samreid commented 3 days ago

I read the recent commits and everything seems reasonable. I tested by renaming a tandem and running grunt pre-commit --phet-io-api and it correctly caught the change. Closing.

phet-dev commented 1 day ago

Reopening because there is a TODO marked for this issue.

samreid commented 1 day ago

I can address these TODO's, I forgot to search them during the code review. Leaving self-assigned.

samreid commented 8 hours ago

I'm uncertain what to do about getStringMap TODO, and the other 3 todos are unclear whether they were meant to be a question for the review. @zepumph can you please advise?