Open zepumph opened 1 week ago
export default
I got an error when building phet-io with this import:
Error: Cannot find module '../../../chipper/js/phet-io/phetioCompareAPIs.js'
Converted and fixed in the above. The webpack build was ignoring files from /phet-io/
in phet brand build (what phet-io-wrappers standalone was build in).
@samreid can you please give a spotcheck. Mostly for the typescript in chipper/js/phet-io/
I read the recent commits and everything seems reasonable. I tested by renaming a tandem and running grunt pre-commit --phet-io-api
and it correctly caught the change. Closing.
Reopening because there is a TODO marked for this issue.
I can address these TODO's, I forgot to search them during the code review. Leaving self-assigned.
I'm uncertain what to do about getStringMap
TODO, and the other 3 todos are unclear whether they were meant to be a question for the review. @zepumph can you please advise?
https://github.com/phetsims/phet-io/issues/1951 https://github.com/phetsims/perennial/issues/410 https://github.com/phetsims/perennial/issues/403 https://github.com/phetsims/chipper/issues/1465
This typescript module can then be used in sim AND build-tools code.