search

phetsims / chipper

Tools for developing and building PhET interactive simulations.
MIT License
11 stars 14 forks source link

Investigate ESLint #235

Closed samreid closed 8 years ago

samreid commented 8 years ago

In #195 we determined that JSHint does not provide support new linting rules or tests. However, it seems like https://github.com/eslint/eslint is becoming very popular and it looks like it has backward support for JSHint rules and the ability to add your own rules.

If we are going to be adding more of our lint style rules like in #195 then we may want to invest in ESLint. No plans to look into it now but wanted to bring it up for future investigation.

pixelzoom commented 8 years ago

Does --disable-eslint-cache delete caches? Or just turn off caching? If the latter, that doesn't solve the problem. If a rule's code is changed, the caches need to be deleted.

samreid commented 8 years ago

Does --disable-eslint-cache delete caches?

It just disables it for the current run, the cache is not deleted.

AshrafSharf commented 8 years ago

@samreid please let me know what is the resolution on this? I am using windows machine. Would setting the idea config or git global config solve the problem?

samreid commented 8 years ago

@AshrafSharf we have removed the line ending rule from the linting rules and will be discussing the issue shortly in #380