phetsims / chipper

Tools for developing and building PhET interactive simulations.
MIT License
11 stars 14 forks source link

Provide a different copyright statement for non-phet brands #310

Open samreid opened 9 years ago

samreid commented 9 years ago

When building a simulation with a non-phet brand, the copyright header in the html reads like so: I built an "adapted-from-phet hooke's law":

<!--
‪Hooke's Law‬ 1.0.0-dev.27
Copyright 2002-2015, Regents of the University of Colorado
PhET Interactive Simulations, University of Colorado Boulder

This file is licensed under Creative Commons Attribution 4.0
For alternate source code licensing, see https://github.com/phetsims
For licenses for third-party software used by this simulation, see below
For more information, see http://phet.colorado.edu/en/licensing/html

The PhET name and PhET logo are registered trademarks of The Regents of the
University of Colorado. Permission is granted to use the PhET name and PhET logo
only for attribution purposes. Use of the PhET name and/or PhET logo for promotional,
marketing, or advertising purposes requires a separate license agreement from the
University of Colorado. Contact phethelp@colorado.edu regarding licensing.
-->

For custom brands and non-phet brands, we should have different statements here.

pixelzoom commented 9 years ago

This is handled in afterRequirejsBuild.js, search for "htmlHeader =".

pixelzoom commented 9 years ago

Recommended to move the HTML header text to chipper/build.json, where it can be loaded by brand.

pixelzoom commented 9 years ago

Question for developer meeting: Should we move the HTML header text to chipper/build.json? The alternative is a hard-coded switch on all phet brand names ('phet', 'phet-io', 'adapted-from-phet').

samreid commented 9 years ago

Move it to the brand itself?

pixelzoom commented 9 years ago

Move it to the brand's hash in chipper/build.json. Here's an example for 'phet-io', note the {0} for filling in the current year.

{
  ...
  "phet-io": {
    "preload": [
      "../sherpa/lib/jsondiffpatch-0.1.31.js",
      "../together/js/together.js",
      "../together/js/SimIFrameAPI.js",
      "../together/js/togetherEvents.js",
      "../together/js/datamite.js",
      "../together/js/api/TogetherCommon.js"
    ],
    "licenseKeys": [
      "jsondiffpatch-0.1.31.js"
    ],
    "htmlHeader":  'Copyright 2002-{0}, Regents of the University of Colorado ... '
}
pixelzoom commented 9 years ago

What do we want the header to read if it's a non-phet brand?

pixelzoom commented 9 years ago

8/25/15 dev meeting consensus: To proceed, we need @ariel-phet or @kathy-phet to tell us:

What should the copyright header read for non-phet brands? (e.g., "my-company")
Should it default to the 'phet' brand header, blank, something else? Should the custom brand be able to specify its own html header?

pixelzoom commented 9 years ago

Discuss at 8/27/15 interoperability meeting.

jbphet commented 9 years ago

@kathy-phet is going to talk to the TTO people and get back to us about us.

samreid commented 8 years ago

@kathy-phet reviewed license things with Molly and we are in good shape. @kathy-phet will double check whether this a special case.