search

phetsims / chipper

Tools for developing and building PhET interactive simulations.
MIT License
11 stars 14 forks source link

Does chainsBuildTest.js support oneOff builds correctly? #670

Open zepumph opened 6 years ago

zepumph commented 6 years ago

I was getting failing tests because the name of the oneOff wasn't showing up in the name of the local chipper build:

 Michael /e/zepumph/Programming/PHET/git/chains (master)
 $ grunt --brands=phet,phet-io --oneOff=foobar
Running "lint-all" task

Running "clean" task

Running "build" task
Building runnable repository (chains, brands: phet, phet-io)
Building brand: phet
>> require.js optimization for brand: phet complete (3241834 bytes)
>> Minification for phet complete
>> Require.js: 923613 bytes
>> Preloads: 184819 bytes
>> Mipmaps: 24778 bytes
Building brand: phet-io
>> require.js optimization for brand: phet-io complete (3417526 bytes)
>> Minification for phet-io complete
>> Require.js: 974063 bytes
>> Preloads: 202932 bytes
>> Mipmaps: 32426 bytes

Done.

 Michael /e/zepumph/Programming/PHET/git/chains (master)
 $ ls build/phet/
chains_en_iframe_phet.html  chains-128.png              chains-twitter-card.png
chains_en_phet.html         chains-600.png              dependencies.json

But the build tests expect the oneOff name in the file: assertFileExistence( assert,../chains/build/phet/chains_${locale}_phet${oneOffSuffix}.html);

@jonathanolson for local chipper builds, are oneOffs even a thing? I only see oneOff code in perennial.

jonathanolson commented 6 years ago

@jonathanolson for local chipper builds, are oneOffs even a thing? I only see oneOff code in perennial.

One-offs are something that shows up in the package.json version and is part of the deployment. It looks like the failing test should have been removed. Any objections to removing it?

zepumph commented 6 years ago

Sounds good, I can take care of it if you want. I was thinking about keeping the the one-off build and test, but removing the test on naming that expects the addition of the oneOff string to the filename. Let me know if you have any objections to that @jonathanolson.

jonathanolson commented 6 years ago

I'm not exactly sure how that would work. It actually may make sense to have a dedicated branch for testing one-off versions (where we'd also have to modify the test).

Self-assigning myself for potentially that.

zepumph commented 6 years ago

Let me know what else I can do. Test removed in https://github.com/phetsims/chipper/commit/ce66837245a794c07d662e72615c8cb606b58eff