Closed samreid closed 3 years ago
@ariel-phet asked me to investigate. Here were the results on my machine (MacOS 10.14.6):
PhETs-MacBook-Pro:website-meteor volta$ node -v
v14.15.0
PhETs-MacBook-Pro:website-meteor volta$ cd ../chipper
PhETs-MacBook-Pro:chipper volta$ rm -rf node_modules/
PhETs-MacBook-Pro:chipper volta$ npm install
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
> fsevents@1.2.13 install /Users/volta/phet/git/chipper/node_modules/watchpack-chokidar2/node_modules/fsevents
> node install.js
SOLINK_MODULE(target) Release/.node
CXX(target) Release/obj.target/fse/fsevents.o
SOLINK_MODULE(target) Release/fse.node
> fsevents@1.2.13 install /Users/volta/phet/git/chipper/node_modules/webpack-dev-server/node_modules/fsevents
> node install.js
SOLINK_MODULE(target) Release/.node
CXX(target) Release/obj.target/fse/fsevents.o
SOLINK_MODULE(target) Release/fse.node
> puppeteer@2.1.1 install /Users/volta/phet/git/chipper/node_modules/puppeteer
> node install.js
Downloading Chromium r722234 - 116.4 Mb [====================] 100% 0.0s
Chromium downloaded to /Users/volta/phet/git/chipper/node_modules/puppeteer/.local-chromium/mac-722234
npm WARN notsup Unsupported engine for pngjs@0.4.0: wanted: {"node":"0.8.x"} (current: {"node":"14.15.0","npm":"6.14.8"})
npm WARN notsup Not compatible with your version of node/npm: pngjs@0.4.0
npm WARN notsup Unsupported engine for watchpack-chokidar2@2.0.0: wanted: {"node":"<8.10.0"} (current: {"node":"14.15.0","npm":"6.14.8"})
npm WARN notsup Not compatible with your version of node/npm: watchpack-chokidar2@2.0.0
added 1061 packages from 1389 contributors and audited 1063 packages in 48.598s
52 packages are looking for funding
run `npm fund` for details
found 3 vulnerabilities (1 low, 1 moderate, 1 high)
run `npm audit fix` to fix them, or `npm audit` for details
I did not see the errors that @samreid described, but this line is concerning:
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
It looks like webpack-dev-server
has a dependency on fsevents 1. Our current version is 3.10.1, but the current version listed at https://webpack.js.org/configuration/dev-server/ is 5.3.2. I don't know what this library is used for, so I can't make a recommendation of how to proceed.
@samreid have you reinstalled xcode dev tools?
Not recently, self assigning to try that in the future.
When I ran a command to install the xcode dev tools, it said I already had them:
~/apache-document-root/main/chipper$ xcode-select --install
xcode-select: error: command line tools are already installed, use "Software Update" to install updates
Running npm list
doesn't mention node-gyp anywhere.
I'm not sure what to investigate next, or how to know if this is even a problem. Tagging for developer meeting to touch base and decide next steps.
JO: I don't see this problem on Node 14 on Mac.
AP: Let's close this issue, since we don't see any symptoms of it.
CM: I haven't seen anything like this.
MK: There is a newer version of webpack dev server. I tried it, but it still had the deprecation warning.
Since this seems related to webpack-dev-server, it seems not too important. Or when we are doing that more, we can re-investigate if it causes problems.
Just pasting the output from my windows 10 machine, node version 14.15.0. No errors, but there are warnings related to "fsevents" and "chokidar".
Jesse@DESKTOP-F2K2K7E MINGW64 ~/Documents/Development/phetsims/chipper (master)
$ npm install
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
> puppeteer@5.5.0 install C:\Users\Jesse\Documents\Development\phetsims\chipper\node_modules\puppeteer
> node install.js
Chromium (818858) downloaded to C:\Users\Jesse\Documents\Development\phetsims\chipper\node_modules\puppeteer\.local-chromium\win64-818858
npm WARN notsup Unsupported engine for pngjs@0.4.0: wanted: {"node":"0.8.x"} (current: {"node":"14.15.0","npm":"6.14.8"})
npm WARN notsup Not compatible with your version of node/npm: pngjs@0.4.0
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.2 (node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules\watchpack-chokidar2\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules\webpack-dev-server\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
added 1061 packages from 613 contributors and audited 1066 packages in 54.494s
55 packages are looking for funding
run `npm fund` for details
found 3 vulnerabilities (1 low, 1 moderate, 1 high)
On second thought, I'd like to understand what dependency is causing this, and to see if updating a dependency resolves it.
I updated everything in package.json to latest, and still saw this problem on npm install
. Closing again.
Related to https://github.com/phetsims/chipper/issues/990 After updating to Node 14, then cleaning node_modules and running
npm install
, I see these errors:Assigning to @ariel-phet to prioritize and delegate.