search

phetsims / circuit-construction-kit-ac

"Circuit Construction Kit: AC and DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

Where should the code for inductors and capacitors go? #3

Closed samreid closed 5 years ago

samreid commented 5 years ago

I asked on Slack:

Sam Reid [11:32 AM] I’m starting on CCK AC, which is based on CCK DC (built on CCK Common repo) and adds capacitors, inductors and charts. I should put the AC specific stuff in the AC repo, not in the common repo, right?

Michael Kauzmann [11:32 AM] Will there be more than one repo that uses the AC stuff? Like CCK-AC and CCK-ACDC?

Sam Reid [11:33 AM] Maybe one day there will be an “Energy” CCK that depends on CCK-AC

samreid commented 5 years ago

I'm inclined to put the AC specific code in the AC repo, so that it doesn't impact DC at all. But I wasn't sure if that was contraindicated by other concerns, or if we have other policies for putting all code in one shared repo.

samreid commented 5 years ago

@zepumph added:

Also, for GFL and inverse common suite sims, we have a common repo, which three two sims extend from, and then a basics version that extends GFL. I could foresee any sim CCK that needed AC in the future just extending from CCK AC as needed.

samreid commented 5 years ago

Decision made and documented in https://github.com/phetsims/circuit-construction-kit-common/issues/447, code and issues will go in "common" and that is working out nicely during initial development.