Solder joint can become transparent

phetsims / circuit-construction-kit-black-box-study

Circuit Construction Kit: Black Box by PhET Interactive Simulations

GNU General Public License v3.0

0 stars 1 forks source link

Solder joint can become transparent #42

Open samreid opened 7 years ago

samreid commented 7 years ago

From https://github.com/phetsims/circuit-construction-kit-black-box-study/issues/36#issuecomment-277319605

In 1.0.8-dev.9, I noticed that the solder joint can become transparent if you

Go to Black Box on startup. Solder joint looks fine.
Switch to Test, and then back to Explore.
Solder joint is now transparent and remains transparent, even when components are attached.

I retested 1.0.8-dev.4, and the issue is also present there.

samreid commented 7 years ago

I'm not seeing this problem in master (or I am not following the steps correctly). I did test=>explore=>connect and I saw:

I saw a layering problem (solder goes to the back), but not a transparency problem. I'll leave this open for @arouinfar to review in the next RC.

arouinfar commented 7 years ago

@samreid here's what I saw in rc.2. On startup, the solder is properly rendered. After switching to test and back to explore, the solder becomes transparent. Attaching additional wires reveals the a layering problem (wire above solder).

solder_layering_3

arouinfar commented 7 years ago

@samreid in rc.6 the solder no longer becomes transparent. However, wires attached to any of the black box or wire stub vertices will be incorrectly layered on top. This is not a blocking issue for Stanford, so no need to address it until after we deliver a version to them.

samreid commented 7 years ago

Unassigning until we start working on this sim for production.