search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 11 forks source link

Unchecked elements may still have collumns #1015

Closed KatieWoe closed 1 week ago

KatieWoe commented 1 week ago

Device Samsung OS Win 11 Browser Chrome Problem Description For https://github.com/phetsims/qa/issues/1170 When a probe is put back in the toolbox after collecting data the column for it in the tables remains. If you pull that tool back out, you'll see it's box is unchecked, but it's column remains. Visuals uncheckedbutstillthere

Nancy-Salpepi commented 1 week ago

Noting that in https://github.com/phetsims/circuit-construction-kit-common/issues/1002 the second to last bullet says:

Manually collecting data for series ammeter readings. Data columns should be added or removed automatically as series ammeters are created or destroyed.

This currently only works before data collection occurs. Otherwise, you get what KW reported above.

kathy-phet commented 1 week ago

@KatieWoe @Nancy-Salpepi - This was the desired behavior, and apparently a modification that happened after the original behavior was described. If there is data, the column is NOT hidden.

Closing.