Light Bulb stays lit during short circuit

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

10 stars 11 forks source link

Light Bulb stays lit during short circuit #245

Closed ariel-phet closed 3 years ago

ariel-phet commented 7 years ago

A twitter user pointed out that in the Java version during a short circuit the bulb stays lit (confusing to students). This is incorrect and should be addressed in the HTML5 version. See screenshot below, in this scenario the short circuit electrons are moving quickly and the bulb side are frozen (as they should be) but the bulb is still lit.

@samreid please be aware of this issue as you are dealing with the "fire" code. Not sure if it is still a problem or not.

arouinfar commented 3 years ago

I'm comfortable closing this issue @samreid. Under normal circumstances (standard batteries with standard bulbs, high-V batteries with high-R bulbs), the bulb will not stay lit when shorted.

samreid commented 3 years ago

Reopening and marking for cherry-picking.

phet-steele commented 3 years ago

Looks good in phetsims/QA/issues/633.