Vertex boolean properties should have `is` prefix

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

10 stars 10 forks source link

Vertex boolean properties should have `is` prefix #834

Closed arouinfar closed 2 years ago

arouinfar commented 2 years ago

Discovered in #797

Vertices have draggableProperty and selectedProperty which both behave nicely. However, the name is a bit of a departure from the other boolean properties such as isEditableProperty and isCuttableProperty (to name a few).

@samreid I think it would be nice to continue with the is prefix here too, but it can wait until the full release.

samreid commented 2 years ago

This would be good to do before the imminent milestone.

samreid commented 2 years ago

Fixed and ready for review.

arouinfar commented 2 years ago

Looks good, thanks @samreid