phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

negative ammeter readings not maintained in Studio and State wrappers #839

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 12.0.1

Browser Safari

Problem description For https://github.com/phetsims/qa/issues/772

In Studio and State wrappers, the negative sign for current doesn't appear in the downstream/launched sim. This happens on both screens.

Steps to reproduce In State:

  1. Make a simple circuit in the intro screen
  2. Attach ammeter
  3. Go to PhET-iO menu > Options to select "signed" for ammeter readout
  4. Reverse battery in the circuit--the upstream sim will have a negative reading while the downstream sim in still positive

Visuals

Screen Shot 2022-02-04 at 8 03 07 AM
arouinfar commented 2 years ago

@samreid I'm tagging this for the preview milestone to make sure we let the client know that this is a known bug. However, I don't think it needs to be fixed until the production version.

arouinfar commented 2 years ago

I've documented this as a known issue, so switching the milestone

samreid commented 1 year ago

I fixed this by instrumenting the current sense property, closing.