search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Taking out fuse and putting it back prevents launching sim #843

Closed KatieWoe closed 2 years ago

KatieWoe commented 2 years ago

Device Dell OS Win 11 Browser Firefox Problem Description For https://github.com/phetsims/qa/issues/772. If you take the fuse out of the carousel, and then put it back, a launched sim from studio will no longer load. The console throws an error that says it is impossible to set state. In order to fix this you need to refresh the studio page.

Steps

  1. Go to the lab screen in studio
  2. Drag out the fuse
  3. Drag the fuse back to the carousel
  4. Launch the sim

Visuals

impossibletosetstate

consoleerror

KatieWoe commented 2 years ago

Doesn't seem to happen to the state wrapper unless you press the launch button.

arouinfar commented 2 years ago

@samreid this looks like a bug that can negatively impact the client's usage. I recommend we try fixing this before sending the client another version, but if that's not feasible it should be documented as a known bug.

samreid commented 2 years ago

Fuse.isRepairableProperty was not being disposed. That was corrected in https://github.com/phetsims/circuit-construction-kit-common/commit/df80074f680e0ac01fbe705e50ddbd0496bc24f7. This is likely fixed, and ready for testing in next dev version.

samreid commented 2 years ago

Can you please test/review this on master using phettest? Please close if it seems corrected.

KatieWoe commented 2 years ago

Looks fixed on master