search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Carousel's Next/Previous buttons do not stay disabled in Studio #844

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 12.0.1

Browser Safari

Problem description For https://github.com/phetsims/qa/issues/772 in the Studio Wrapper:

If the previous button and next button are disabled, they will be enabled when the sim is launched. This happens on both screens.

Steps to reproduce

  1. In studio, navigate to the second page of the carousel on either screen
  2. Disable the previous button (view.circuitElementToolbox.carousel.previousButton.enabledProperty)
  3. Disable the next button (view.circuitElementToolbox.carousel.nextButton.enabledProperty)
  4. Launch the sim

Visuals carouselbuttons

arouinfar commented 2 years ago

Thanks @Nancy-Salpepi. I think the solution here is that carousel.nextButton.enabledProperty and carousel.previousButton.enabledProperty should be phetioReadOnly: true. However, that should be handled in a separate issue for the PhET-iO design patterns for carousel. Self-assigning to open an issue in sun.

arouinfar commented 2 years ago

Design issue for carousel linked above, closing.

KatieWoe commented 2 years ago

This has not been done in the newest dev. Reopening for https://github.com/phetsims/qa/issues/774

notdone
arouinfar commented 2 years ago

Thanks @KatieWoe this issue will be addressed in https://github.com/phetsims/sun/issues/736 where the button's enabledProperty will be made read-only.