phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Add top-level visibleProperty to sourceResistanceControl and wireResistivityControl #856

Closed arouinfar closed 1 year ago

arouinfar commented 2 years ago

The sourceResistanceControl and wireResistivityControl in the Advanced AccordionBox could both use a top-level visibleProperty so the entire slider could be hidden in one go.

@samreid please create:

arouinfar commented 2 years ago

Note: once created, these should be phetioFeatured in the overrides.

samreid commented 2 years ago

I instrumented and featured the visibleProperty. If it is preferable, I can remove that phetioFeatured from the code and move it to the overrides. Also referring to https://github.com/phetsims/phet-io/issues/1873 which discusses where this metadata should live.

arouinfar commented 1 year ago

Thanks @samreid. The behavior looks good in Studio. Since https://github.com/phetsims/phet-io/issues/1873 hasn't been resolved, I'm not sure where we should specify phetioFeatured: true or if this issue can be closed, so back to you.

samreid commented 1 year ago

It doesn't seem to be causing problems to specify this in the code, so let's leave it as is. If we decide otherwise in https://github.com/phetsims/phet-io/issues/1873, we can change that easily.