search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Add lifelike/schematic icons to lightBulbToolNode and realLightBulbToolNode #859

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 2 years ago

The lightBulbToolNode (on both screens) and the realLightBulbToolNode (on lab screen) are missing : lifelikeIcon.resistorIcon lifelikeIcon.resistorIcon.visibleProperty schematicIcon.resistorIcon schematicIcon.resistorIcon.visibleProperty

From my slack conversion with @arouinfar, all items in the carousel should have these.

samreid commented 2 years ago

It was requested to uninstrument the lifelikeIcon and schematicIcon in https://github.com/phetsims/circuit-construction-kit-common/issues/855, @arouinfar can you please review if anything needs to be done here?

arouinfar commented 1 year ago

Thanks @Nancy-Salpepi @samreid. Based on the current behavior in master, I don't think there's anything we need to do here.