search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Should checkboxes and radio buttons have customizable text? #870

Closed arouinfar closed 1 year ago

arouinfar commented 2 years ago

We often (but not always) instrument the title text of checkboxes and radio buttons. Should these strings be instrumented?

image image
arouinfar commented 2 years ago

2/24/22 design meeting, we decided to instrument the strings in the screenshot above. Over to @samreid.

samreid commented 2 years ago

I added "label" subcomponents for each of the items above. Ready for review.

arouinfar commented 1 year ago

Now that PhET-iO sims contain all of the rosetta strings, this sort of request is no longer necesary. That said, I reviewed the tree in master, and the checkboxes and radio buttons now all contain links to the appropriate stringProperty, which is great. Closing.