search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Figure out updateRenderer() @protected status #877

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

While working on https://github.com/phetsims/chipper/issues/1237, it seems like many of those overrides are not actually protected, but I didn't know how to proceed. Please help me out @samreid

samreid commented 2 years ago

I committed the proposed fix, @zepumph would you like to spot check?

zepumph commented 2 years ago

Yes perfect, and exactly what I would have done, I just didn't if it was too strict for how you wanted your code. Thanks!