phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Extend Phase Shift range to 240 degrees #879

Closed arouinfar closed 1 year ago

arouinfar commented 2 years ago

In https://github.com/phetsims/circuit-construction-kit-common/issues/878, a user requested the ability to create a three-phase AC voltage. In general, their goals are better suited to a household/electrician flavor of CCK, but it seems like increasing the range of the Phase Shift to 240 degrees could achieve some of their goals.

image

Let's consider this suggestion when republishing CCK:AC with PhET-iO.

samreid commented 1 year ago

In today's meeting @arouinfar @matthew-blackman and I agreed this would be good to try for the AC milestone.

samreid commented 1 year ago

The phase range is -180 to +180 degrees. So a 3-phase voltage can be made like: -120, 0, +120. Can this issue be closed?

samreid commented 1 year ago

@matthew-blackman tested this, and was able to make the 3-phase voltage offset using the phases described above. @arouinfar what do you think?

arouinfar commented 1 year ago

So a 3-phase voltage can be made like: -120, 0, +120.

I forgot about negative phase shifts!

@matthew-blackman tested this, and was able to make the 3-phase voltage offset using the phases described above. @arouinfar what do you think?

I don't think there's anything we need to do here, closing.