search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Build failure: Error: Build aborted, circuit-construction-kit-ac failed with exit code 1 stdout: #887

Closed samreid closed 2 years ago

samreid commented 2 years ago

I saw this build failure:

Build failure: Error: Build aborted, Error: grunt --allHTML --debugHTML --brands=phet --locales=om in ../circuit-construction-kit-ac failed with exit code 1
stdout:
Running "lint-all" task

Running "report-media" task

Running "clean" task

Running "build" task
Fatal error: tsc failed with code: 2
stdout:
./phet-core/js/Namespace.js(8,19): error TS6307: File '/data/share/phet/build-server/phet-core/js/isHMR.js' is not listed within the file list of project '/data/share/phet/build-server/griddle/tsconfig.json'. Projects must list all files or use an 'include' pattern.
./phet-core/js/phetCore.js(4,23): error TS6307: File '/data/share/phet/build-server/phet-core/js/Namespace.js' is not listed within the file list of project '/data/share/phet/build-server/griddle/tsconfig.json'. Projects must list all files or use an 'include' pattern.
  The file is in the program because:
    Imported via './Namespace.js' from file '/data/share/phet/build-server/phet-core/js/phetCore.js'
    Imported via '../../phet-core/js/Namespace.js' from file '/data/share/phet/build-server/axon/js/axon.js'
    Imported via '../../phet-core/js/Namespace.js' from file '/data/share/phet/build-server/tandem/js/tandemNamespace.js'
    Imported via '../../phet-core/js/Namespace.js' from file '

I checked out that branch and have the same problem locally.

samreid commented 2 years ago

This problem was caused by an errant "griddle" appearing in the tsconfigs. It didn't have griddle in the SHAs so was trying to type check an incompatible version (whatever else was checked out).

samreid commented 2 years ago

I patched the dependencies in the commits, and updated of the dependencies file. I re-triggered the build following a command given to me by @mattpen.

I also noticed many lint errors and a chipper SHA inconsistency.

Also, the dependencies.json commit failed from a precommit hook, so I think the build may have a bad file for that.

samreid commented 2 years ago

@jonathanolson @zepumph and I worked through several problems and got 1.0.2 published, and the om translation looks good. @jbphet do you have a way to notify that translator?

jbphet commented 2 years ago

@jbphet do you have a way to notify that translator?

@oliver-phet can do that. Assigning to him.

oliver-phet commented 2 years ago

Translator notified. It appears that the translation was published correctly to the website, but I notified the translator they may want to review.