search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Ensure coverage of phet-io instrumentation for elements in the circuitElementControlNode #896

Closed samreid closed 1 year ago

samreid commented 1 year ago

Today while working on #831 @matthew-blackman discovered there was poor coverage of phet-io instrumentation in what we hope to call the circuitElementControlNode. For example, in the resistor and fuse controls, and light bulb. We should add better instrumentation there.

samreid commented 1 year ago

All parts of the resistor controls seem well-instrumented:

image
samreid commented 1 year ago

I saw equally good coverage for the fuse and light bulb controls. @matthew-blackman am I checking the right thing? Does this issue seem ready to fix?

matthew-blackman commented 1 year ago

I tested this in studio and the controls all look instrumented for resistors, bulbs and fuses. Closing this issue.