search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

DC-specific circuit elements and features should not appear in the AC studio tree #900

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

We should not add DC-only features (high-voltage and high-resistance components) to AC because they have not been tested in an AC environment and go beyond the scope of the learning goals.

matthew-blackman commented 1 year ago

@samreid and I agree that the way we are guarding against creating circuit nodes for non-existent circuit element groups in CircuitNode.ts is not as robust as it could be. We recommend doing all of the guarding for non-existent component groups in Circuit.ts, and null-checking for those groups in CircuitNode.ts and CircuitElementToolFactory.ts. This will only apply to groups of screen-specific components.

samreid commented 1 year ago

Great, nice work! I just factored out one variable. I regenerated the API files in https://github.com/phetsims/phet-io-sim-specific/commit/a3554143882d156300f6f3fa5c09c69e85e6b836. Everything else seems good. Closing.