search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

'Reset fuse' button is misaligned vertically #902

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

See screenshot below. It looks like the 'reset fuse' button should be vertically centered, not bottom-justified.

Screen Shot 2022-11-29 at 11 37 45 AM
samreid commented 1 year ago

Thanks, I changed align to center, and it seems much better now:

image

Not sure how this was working before--I didn't see much other layout code for the trash button, etc.

Can you please spot check the layouts for a few component types and close if all seems well?

samreid commented 1 year ago

@matthew-blackman and I improved 2 buttons and want to apply the pattern to the remaining 2 buttons.

@matthew-blackman volunteered to do the other 2 buttons, each labeled with TODOs.

matthew-blackman commented 1 year ago

Closing as previous commit applies the sizing fix to all edit buttons