CCKCConstants should not be modified

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

10 stars 10 forks source link

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

I found this nasty bit in circuit-construction-kit-dc-main.ts and circuit-construction-kit-dc-vitural-lab-main.ts:

CCKCConstants.CAROUSEL_SCALE = CCKCConstants.DC_CAROUSEL_SCALE;

Reaching into (what is expected to be) a constants file and changing a value? Please tell me that this is a temporary hack.

samreid commented 1 year ago

@matthew-blackman and I finished this, nice work! Closing.