@ts-expect-error in circuit-construction-kit-dc-main.ts

[pixelzoom]

This line in circuit-construction-kit-dc-main.ts:

if ( !window.circuitConstructionKitTestSuite ) {

... was causing CT errors and blocking other devs, so I added a @ts-expect-error to unblock.

The TS error was:

TS2339: Property 'circuitConstructionKitTestSuite' does not exist on type 'Window & typeof globalThis'

Oddly, the same line was not a problem in the other CCK main.ts files.

[pixelzoom]

A couple other things:

• Setting a global on window is a code smell. PhET agree to namespace globals.
• There is zero documentation for circuitConstructionKitTestSuite, which made fixing it more expensive.

[pixelzoom]

The other 2 mains are JavaScript files. And in those files, WebStorm flags window.circuitConstructionKitTestSuite as “Unresolved variable circuitConstructionKitTestSuite”. So I'm guessing your best options for resolving this in TypeScript is something like:

- // @ts-expect-error
- if ( !window.circuitConstructionKitTestSuite ) {
+ type WindowKey = keyof typeof window;
+ if ( !window[ 'circuitConstructionKitTestSuite' as WindowKey ] ) {

[samreid]

Fixed, closing.