search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Replace usages of merge with optionize / combineOptions #914

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

This is in line with the overall TS sim patterns

matthew-blackman commented 1 year ago

@samreid I replaced all instances of merge with the appropriate counterpart and ended up finding some rogue options that were not being used anywhere else. I flagged them both with TODOs and "@SamReid" if you can take a look

samreid commented 1 year ago

Thanks, the changes look good and I removed the stale options. I also converted an occurrence of _.merge. Closing.