search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Review the studio tree #917

Closed samreid closed 1 year ago

samreid commented 1 year ago

We would like to take a close look at the studio tree to make sure it is well-designed.

samreid commented 1 year ago

Some notes about trouble in the studio tree in https://github.com/phetsims/circuit-construction-kit-common/issues/858#issuecomment-1371735015, regarding the voltmeter/ammeter panel.

samreid commented 1 year ago

For my reference, notes are being taken in:

https://docs.google.com/document/d/1z8ECC0PIi7gGQ8WRpp3mFwzX9SrXH48EOJW3gSYii90/edit
samreid commented 1 year ago

Are all reported issues tracked elsewhere? Can this issue be closed?

arouinfar commented 1 year ago

Yes, let's close.

matthew-blackman commented 1 year ago

fuseRepairButton visibleProperty should not be readonly

matthew-blackman commented 1 year ago

@arouinfar FuseRepairButton ready for your review, please confirm and then close if it looks good.

arouinfar commented 1 year ago

@matthew-blackman it's a bit more complicated than we thought, so I opened up #956.