search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

`draggingProbesWithBodyProperty` should be read-only #932

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

Related to #917

When removing a tool from the toolbox, draggingProbesWithBodyProperty is true and its body and probe(s) move together as a unit. Once in the play area, the tool's body and probe(s) move independently and draggingProbesWithBodyProperty is false. If you try to set draggingProbesWithBodyProperty back to true and then move the tool, its probe(s) will snap back to the default position.

The model should be in control of draggingProbesWithBodyProperty. There isn't any need for clients to be in control of it, so let's make it phetioReadOnly: true.

samreid commented 1 year ago

@liammulh and I reviewed this issue and wanted to double check: could we just uninstrument draggingProbesWithBodyProperty altogether? We cannot see how phet-io clients would use it, it seems like an implementation detail that could be eliminated. @arouinfar what do you think?

arouinfar commented 1 year ago

Uninstrumenting sounds reasonable to me @samreid @liammulh. I also can't think of a reason why clients should care about draggingProbesWithBodyProperty.

samreid commented 1 year ago

Uninstrumented, closing.