search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

If seriesAmmeterToolNode is alone in the toolbox, the top padding is too small #950

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

Hiding the voltmeter and non-contact ammeters in the Lab screen causes the series ammeter icon to appear too close to the top of the panel.

Screen Shot 2023-01-25 at 8 35 36 AM
AgustinVallejo commented 1 year ago

Will take a look!

matthew-blackman commented 1 year ago

I added a topMargin of 10 above the series ammeter icon, which only becomes visible when all other meter icons are hidden. Let me know how this looks @arouinfar and we can adjust the margin.

Screen Shot 2023-01-30 at 11 59 10 AM
matthew-blackman commented 1 year ago

@samreid adding you to assignees for checking if adding the additional HBox with topMargin is an acceptable solution

arouinfar commented 1 year ago

The updated padding looks good to me @matthew-blackman, thanks!

samreid commented 1 year ago

I reviewed the code changes and everything seems great. Thanks for documenting it. Closing.