search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

DisplayOptionsPanel.displayOptionsRadioButtonGroup should have a featured enabledProperty #955

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

While working on the featured overrides, @arouinfar and I noticed that the current type radio button groups in the display options panel do not have an enabledProperty. This should be added in and also featured.

matthew-blackman commented 1 year ago

@arouinfar radio button groups all have a featured enabledProperty now. Ready for you to review.

arouinfar commented 1 year ago

The Current Type radio buttons look good, but I think you missed the lifelike/schematic group. My understanding is that today's decision applied to both Rectangular and Aqua radio buttons.

arouinfar commented 1 year ago

Scratch that, actually. I see no reason for the lifelike/schematic buttons to have enabledProperty or visibleProperty. Today's decision was about what we are doing at the sun level. Let's leave things alone in CCK, closing.