search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Uninstrument `isEditableProperty` for Real Bulbs #957

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

In https://github.com/phetsims/circuit-construction-kit-common/issues/937, we uninstrumented isColorCodeVisibleProperty and isEditableProperty for irrelevant resistor types. We should do the same for isEditableProperty for Real Bulbs. The property doesn't do anything because Real Bulbs do not have a tunable resistance, so let's uninstrument it.

matthew-blackman commented 1 year ago

Working on this!

samreid commented 1 year ago

@matthew-blackman pushed a fix that we collaborated on. @arouinfar can you please review and close if all is well?

arouinfar commented 1 year ago

Looks good, thanks!