phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Solicit feedback from students, teachers about undo using control-z or command-z #970

Open liammulh opened 1 year ago

liammulh commented 1 year ago

While testing https://github.com/phetsims/qa/issues/900, I kept thinking it would be nice to be able to go back to the way my circuit was before I made a change.

It seems like this is a common feature of web apps, and something students and teachers might want. Perhaps we could solicit some feedback from students and teachers?

samreid commented 1 year ago

From a user's perspective, it would be nice to have undo/redo in the sim, including buttons in the UI so it is more accessible. Some considerations:

matthew-blackman commented 1 year ago

@samreid @zepumph and I discussed with @arouinfar and agree that this would be a very nice feature, but is outside the scope of the PhET-iO release milestone. We decided to come back to this when we are read to implement save/load in the PhET brand version of the sim as well as via studio.

@samreid proposed simplifying this issue by using PhET-iO states to store/reference the history of the circuit. However, it will likely be more performant to implement this with a stack of user actions, with each action also having an inverse action that is triggered by 'undo'.

arouinfar commented 1 year ago

I agree that this would be a great feature, but it seems best to consider when we are ready to support save/load, #151. Deferring.