search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Dragged Voltmeter resets draggingProbesWithBodyProperty in launched standard wrapper #972

Closed samreid closed 1 year ago

samreid commented 1 year ago

Discovered in https://github.com/phetsims/circuit-construction-kit-common/issues/968 and https://github.com/phetsims/qa/issues/900. Dragged Voltmeter resets draggingProbesWithBodyProperty in launched standard wrapper. The effect is that the probes jump to the sides of the voltmeter body on drag even if they were attached to a circuit.

samreid commented 1 year ago

Before starting, I noticed there are many changes to the PhET-iO API files. I'll update those first.

samreid commented 1 year ago

Fixed. @arouinfar and @matthew-blackman is the name draggingProbesWithBodyProperty ok? Please close if acceptable.

matthew-blackman commented 1 year ago

Since draggingProbesWithBodyProperty is a boolean, @zepumph suggested to add the 'is' prefix to the class attribute as well as the PhET-iO ID.

matthew-blackman commented 1 year ago

All variables and PhET-iO ids are now appropriately named. Closing.