phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

'Tap circuit element to edit' is initially missing in launched sim #973

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip and iPad

Operating System 13.1 and iOS 16.3

Browser Safari

Problem description For https://github.com/phetsims/qa/issues/900, in Studio, if I add objects to the play area and then launch the sim, the 'Tap circuit element to edit' message isn't there. It appears after selecting an object or adding another object to the play area.

Steps to reproduce

  1. In Studio, add object to play area --Tap message is on the bottom of the screen
  2. Press Test button --Tap message isn't there

Visuals

https://user-images.githubusercontent.com/87318828/220194037-a9cff05c-fb14-4d6b-ac10-c26070d7bca3.mp4

Nancy-Salpepi commented 1 year ago

I am also seeing odd things in the State Wrapper with this. For example:

  1. Set State Rate = 0
  2. Add a couple of elements to the upstream sim and press Set State Now--the 'Tap circuit' message doesn't appear in the downstream sim
  3. Hit Set State Now again --the message appears in the downstream sim
  4. Press Reset All in the upstream sim and then press Set State Now -- the elements disappear in the downstream sim, but the the 'Tap circuit' message is still there.

https://user-images.githubusercontent.com/87318828/220203295-15c45987-425e-480b-875c-42a577545786.mp4

matthew-blackman commented 1 year ago

@arouinfar agrees that this is important to fix for the PhET-iO release milestone. @samreid @zepumph and I will work on this.

samreid commented 1 year ago

Fixed, @Nancy-Salpepi can you please verify?

Nancy-Salpepi commented 1 year ago

This is working nicely in both Studio and State wrappers now in master 🙂.

samreid commented 1 year ago

Thanks, closing.