Closed Nancy-Salpepi closed 1 year ago
This also applies to language direction rtl/ltr. Elements added with any ltr language will keep units to the right of numbers when locale is changed to any rtl and vice versa.
Code review seems OK. But @arouinfar could you please test readouts for each circuit element type, and switch locales (or use stringTest=dynamic)?
Tested with stringTest=dynamic
and with the steps originally reported, and everything looks good!
For QA, please show the readout for several different circuit element types, and check if it updates when the locale is changed via the preferences dialog.
This looks good in rc.3. Closing!!
Test device MacBook Air M1 chip
Operating System 13.2.1
Browser Chrome/Safari
Problem description For https://github.com/phetsims/qa/issues/908, when I switch locales, the units of existing circuit elements don't change. New Circuit elements added to the play area will display the units for the new locale.
Steps to reproduce
Visuals