phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

Update language in examples.md to refer to 'Get Command' #986

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

In https://github.com/phetsims/studio/issues/298 we updated the get/set interface in Studio. The examples doc references the "Copy Set Value Code" button which no longer exists, so we should update it.

arouinfar commented 1 year ago

Updated in the above commits. The changes happened in the same paragraph as the additions made in #971. However, I made sure not to change any of the text that was added in #971.

arouinfar commented 1 year ago

@samreid @matthew-blackman please review, if all looks good, this is ready for cherry-picking.

samreid commented 1 year ago

Tagging for https://github.com/phetsims/qa/issues/908 in case we use that as the list to cherry-pick.

samreid commented 1 year ago

The updates look reasonable to me, thanks!

matthew-blackman commented 1 year ago

Looks great @arouinfar

samreid commented 1 year ago

For QA, please check that examples.md has text like "The Get Command button will populate the text box ". One platform only.

Nancy-Salpepi commented 1 year ago

I'm confused about this one @samreid . In rc.3 the button in Studio still says 'Copy Set Value Code.'

Screenshot 2023-03-08 at 7 47 16 PM
Nancy-Salpepi commented 1 year ago

The Examples doc has been updated with 'Get Command.'

Nancy-Salpepi commented 1 year ago

In rc.4 the Examples doc has been updated with 'Get Command' and I think the directions are clear on to how to use this button. Closing.