search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 10 forks source link

All PatternStringProperties should be instrumented #990

Open zepumph opened 1 year ago

zepumph commented 1 year ago

From https://github.com/phetsims/phet-io/issues/1942, I passed some tandems through but mostly Tandem.OPT_OUTs, please review this sim's instrumentation of PatternStringProperties in correlation to this sims' phet-io priorities. In general all PatternStringProperties should be instrumented unless they are just symbols or patterns that aren't for i18n purposes.

zepumph commented 6 months ago

This is no longer true. We only instrument PatternStringProperties that make sense for the instrumentation level.