search

phetsims / circuit-construction-kit-common

"Circuit Construction Kit: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
10 stars 11 forks source link

CircuitElementNode startDragListener should use press instead of down for the forwarded event #992

Closed jessegreenberg closed 1 year ago

jessegreenberg commented 1 year ago

While checking on https://github.com/phetsims/joist/issues/769, I noticed that the forwarded press to bring circuit elements out of the toolbox is using DragListener.down (scenery-internal) instead of DragListener.press(). Using press will resolve https://github.com/phetsims/joist/issues/769#issuecomment-1072430805. Ill commit a change for review.

jessegreenberg commented 1 year ago

@samreid would you like to review this change?

samreid commented 1 year ago

Code review looks good and behavior (including during pan/zoom) looks good, thanks, closing.