phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

Be able to "click through" the voltage probe wires #103

Closed kathy-phet closed 7 years ago

kathy-phet commented 7 years ago

In version dev.91, it seems that the voltage probe wires block clicking so when they go over the battery or other elements, it makes it more difficult to grab or highlight those elements for changing values, moving, or deleting. It would be good to make these wires essentially "see through" as far as the mouse is concerned.

samreid commented 7 years ago

Thanks for reporting this issue, @kathy-phet. In the preceding commit I made the voltmeter and ammeter wires unpickable. Here's a dev version with the fix: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.99/circuit-construction-kit-dc_en.html

@kathy-phet or @arouinfar can you please verify? Be aware that dev.99 is many commits beyond dev.91 so cannot be used as a "safe sha" maintenance release.

kathy-phet commented 7 years ago

Thx Sam, I will use 91.

Sent from my iPhone

On Jul 23, 2017, at 3:23 PM, Sam Reid notifications@github.com<mailto:notifications@github.com> wrote:

Assigned #103https://github.com/phetsims/circuit-construction-kit-dc/issues/103 to @kathy-phethttps://github.com/kathy-phet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/phetsims/circuit-construction-kit-dc/issues/103#event-1175298911, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE3FZCVQN-UVs5Z0wxG-nIYjfCSA6aGeks5sQ8fWgaJpZM4OglZ2.

arouinfar commented 7 years ago

Looks good to me @samreid!