Wire is aliased on Firefox and iPad2

phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

11 stars 8 forks source link

Closed samreid closed 7 years ago

samreid commented 7 years ago

Discovered in #109, the wire is aliased in Firefox

samreid commented 7 years ago

@jonathanolson anything we can do about this? It is rendered with toDataURLNodeSynchronous then Image/webgl.

jonathanolson commented 7 years ago

Theoretically, adding back in some vertical padding for the wire may help (keeping the lack of padding at the ends).

Will check for local reproduction.

jonathanolson commented 7 years ago

Cannot reproduce locally:

screen shot 2017-07-27 at 10 39 45 am

What device did this happen on?

samreid commented 7 years ago

The screenshot in the top comment is from Firefox on my MBP retina display:

jonathanolson commented 7 years ago

The retina part may be relevant. Collaborating on this may help.

samreid commented 7 years ago

Same app, no problem.

Let me see if it is a problem in the built version.

samreid commented 7 years ago

It looks equally great in the published version. Not sure what was wrong in my original post. I tried ?webgl=false and it also looked good. Closing.

samreid commented 7 years ago

@phet-steele saw this again on iPad2

jonathanolson commented 7 years ago

I believe @phet-steele said this looked better on his side. @samreid can you confirm?

samreid commented 7 years ago

Looks great, thanks! @jonathanolson anything else to do for this issue?

jonathanolson commented 7 years ago

Nope, closing.