search

phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

The icons and text jump around in the toolbox when changing to schematic #115

Closed samreid closed 7 years ago

samreid commented 7 years ago

The schematic and lifelike icons are different sizes and shapes. We must choose between the following:

  1. Change the icons to have the same dimension. This is problematic because we want some of the grab bag resistors to have different heights for lifelike but same height for schematic.
  2. Relayout the icons when changing between schematic and lifelike. This is problematic because the icons move when changing schematic and lifelike
  3. Allow wonky spacing between items in one of the views. This looks odd and is more complicated to implement.

So I'm going to investigate (2).

samreid commented 7 years ago

I implemented (2) above and published a dev version here: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.112/circuit-construction-kit-dc_en.html

@arouinfar can you please double check this issue?

arouinfar commented 7 years ago

@samreid I think option (2) is looking good. While the objects do noticeably move as the view is switched, it doesn't seem unnatural because the images themselves are changing quite a bit.