search

phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

Highlight region truncated for high resistance bulb on iPad2 #117

Closed samreid closed 7 years ago

samreid commented 7 years ago

image

samreid commented 7 years ago

I haven't been able to reproduce this problem. @phet-steele can you keep your eyes peeled for this sort of this in the next round of testing?

phet-steele commented 7 years ago

@samreid, if a component (any) starts its life in schematic view, then its highlight will fit the size of the schematic, not the normal size. So, switch to schematic view, then drag out a light bulb (don't care which type). Then switch to normal view and drag out another lightbulb. Then you can compare their sizes. Not specific to platform either, I believe.

samreid commented 7 years ago

If I initialize the highlight regions based on the lifelike view, then the schematic view looks like this:

image

@arouinfar is that acceptable? Or should the highlight regions be recomputed when changing between lifelike and schematic?

samreid commented 7 years ago

Proposed fix committed above, @arouinfar can you please double check everything?

http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.121/circuit-construction-kit-dc_en.html

arouinfar commented 7 years ago

Updated highlight looks good! Thanks @samreid.