search

phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

Schematic component dimensions are wrong #122

Closed samreid closed 7 years ago

samreid commented 7 years ago

When dragging out a component in schematic mode, its dimensions are wrong. this was on edge but maybe it happens everywhere

image

samreid commented 7 years ago

Or maybe they are all just wrong now?

samreid commented 7 years ago

Probably introduced after I added caching to fix a spritesheet memory leak.

samreid commented 7 years ago

Proposed fix is here: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.122/circuit-construction-kit-dc_en.html

@arouinfar can you please take a look?

arouinfar commented 7 years ago

When dragging out a component in schematic mode, its dimensions are wrong. this was on edge but maybe it happens everywhere

@samreid I wasn't able to reproduce this in dev.121 in Mac/Chrome or Win10/Edge, so I'm not sure how to verify the fix in dev.122. @phet-steele have you observed this behavior?

samreid commented 7 years ago

To see the buggy version, use any browser and launch http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.121/circuit-construction-kit-dc_en.html

Then switch to schematic and drag out a dog. You should see something like this:

image

arouinfar commented 7 years ago

Thanks @samreid! I had been testing the standard components, not the Grab Bag items. I cannot reproduce the issue in dev.122. Closing.