phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

Can we layer the value text over highlights? #136

Closed phet-steele closed 7 years ago

phet-steele commented 7 years ago

@samreid @arouinfar I'd like to at least raise discussion about the possibility of layering the value text over a highlight box/circle. Currently, I think this looks bad:

screen shot 2017-08-08 at 12 47 06 pm

Here is a poor-man's mockup of a layer change:

screen shot 2017-08-08 at 12 47 06 pm

I prefer the aesthetics of the latter, but I could be swayed either way.

For phetsims/QA#33.

arouinfar commented 7 years ago

Thanks for the mockups @phet-steele! Now that I see the value layered on top, I think it does indeed look nicer.

With the rectangle layered over the values, it's hard to see the voltage as it's being changed. (But one could argue that the user can get this information from the voltage slider's readout.)

@samreid if this is an easy change and won't wreak havoc on the layering simplifications you've already made, then I'd say go for it. Like @phet-steele, I could go either way on this one.

samreid commented 7 years ago

Values are in front of highlight starting in this version: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.142/circuit-construction-kit-dc_en.html

@phet-steele can you please check it?

phet-steele commented 7 years ago

Looks better, thanks guys!

phet-steele commented 7 years ago

Actually, let's have @arouinfar take a look.

arouinfar commented 7 years ago

:+1: